Skip to content

patch adding version specifying + older binary handling for kpt&go install … - #4871

Merged
liamfallon merged 2 commits into
kptdev:mainfrom
Nordix:patch-go-kpt-setup-gh-action-older-binaries
Nov 18, 2026
Merged

liamfallon merged 2 commits into
kptdev:mainfrom
Nordix:patch-go-kpt-setup-gh-action-older-binaries

Conversation

@Catalin-Stratulat-Ericsson

Copy link
Copy Markdown
Contributor

Modified the "Go/Kpt install" GitHub action such that the user can specify version rather than just go.mod only + it can now work with older kpt binaries that dont use the cli/<tag> pathing.

This was requested by @aravindtga here https://github.com/kptdev/porch/pull/1362/changes#r4538904676

And this is also required to be merged before kptdev/porch#1362 to operate as intended

What the action does now

  1. Resolve kpt version: use the kpt-version input if set. Otherwise read it from go.mod. A missing v prefix is added.
  2. Resolve kpt release tag: ask the releases API whether cli/ exists. A 200 means use cli/. A 404 means use the plain . Any other status (a 401 or 5xx, say) fails with a clear error, so a transient problem can't silently choose the wrong layout.
  3. Install kpt: call jaxxstorm with the chosen tag, the same as upstream does today.

…github action

Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
@netlify

netlify Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kptdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 057817a
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6af77b8e14d27e658c198cfa
😎 Deploy Preview https://deploy-preview-4871--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the kpt version-selection and release-tag updates.

No open issues 🎉

What changed in this PR

Updates the shared Go/kpt setup action to support explicit kpt versions and older release tags while retaining version resolution from go.mod.

Changes:

  • Adds a kpt-version input that overrides the version file and accepts versions without a v prefix.
  • Checks for a cli/<version> release, falls back to <version> on HTTP 404, and fails on unexpected responses.
  • Passes the resolved tag to the existing release installer.
File Description
.github/​actions/​setup-go-kpt/​action.yml Adds explicit version selection and release-tag detection for newer and older kpt binaries.

Review effort: Balanced

@aravindtga aravindtga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Added one suggestion.

Comment thread .github/actions/setup-go-kpt/action.yml Resolved
Signed-off-by: Catalin-Stratulat-Ericsson <catalin.stratulat@ericsson.com>
@liamfallon
liamfallon merged commit 679e8ac into kptdev:main Nov 18, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants